Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1446): Added maxwidth to modal CSS #1447

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix(#1446): Added maxwidth to modal CSS #1447

merged 1 commit into from
Nov 9, 2023

Conversation

ArakTaiRoth
Copy link
Collaborator

No description provided.

@ArakTaiRoth ArakTaiRoth linked an issue Nov 3, 2023 that may be closed by this pull request
Bug: Modal width is always 100% #1446
Closed
@chrisolsen
Copy link
Collaborator

As I mentioned in our earlier conversation I thought the reason might have been an earlier made error, which it was.
image

The existing max-width setting got accidentally changed to an incorrect media selector.

@Radha-Alberta Radha-Alberta marked this pull request as ready for review November 6, 2023 18:01
chrisolsen
chrisolsen previously approved these changes Nov 7, 2023
View reviewed changes
amar-ABgov
amar-ABgov previously approved these changes Nov 8, 2023
View reviewed changes
@ArakTaiRoth ArakTaiRoth changed the base branch from BUGFIX to alpha November 9, 2023 20:22
@ArakTaiRoth ArakTaiRoth dismissed stale reviews from amar-ABgov and chrisolsen November 9, 2023 20:22

The base branch was changed.

@ArakTaiRoth ArakTaiRoth merged commit 9ac8d75 into GovAlta:alpha Nov 9, 2023
@ArakTaiRoth ArakTaiRoth deleted the 1446-modal_width branch November 9, 2023 21:19
@tzuge
Copy link
Collaborator

tzuge commented Nov 9, 2023

🎉 This PR is included in version 1.16.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Nov 9, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 9, 2023

🎉 This PR is included in version 4.16.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 10, 2023

🎉 This PR is included in version 1.17.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 10, 2023

🎉 This PR is included in version 4.17.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Nov 27, 2023

🎉 This PR is included in version 4.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Nov 27, 2023
@tzuge
Copy link
Collaborator

tzuge commented Nov 27, 2023

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 21, 2024

🎉 This PR is included in version 2.6.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Feb 22, 2024

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanessatran-ddi vanessatran-ddi vanessatran-ddi approved these changes

@chrisolsen chrisolsen chrisolsen approved these changes

@amar-ABgov amar-ABgov amar-ABgov left review comments

@Radha-Alberta Radha-Alberta Awaiting requested review from Radha-Alberta

Assignees
No one assigned
Labels
released on @alpha Released into alpha. released Released into production.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Modal width is always 100%
5 participants
@ArakTaiRoth @chrisolsen @tzuge @amar-ABgov @vanessatran-ddi